jodhus/spradio-server-django
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Request bounds check and standard HTTP responses.

Browse source
This commit is contained in:
Josh Washburne 2019-05-20 15:56:19 -04:00
parent 5657ac4334
commit 5bb6be7a1d
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
savepointradio/api/views/controls.py
View file

@ -30,11 +30,20 @@ class JustPlayed(APIView):
serializer = JustPlayedSerializer(data=request.data) serializer = JustPlayedSerializer(data=request.data)
if serializer.is_valid(): if serializer.is_valid():
request_pk = serializer.data['song_request'] request_pk = serializer.data['song_request']
try:
song_request = SongRequest.objects.get(pk=request_pk) song_request = SongRequest.objects.get(pk=request_pk)
except SongRequest.DoesNotExist:
return Response({'detail': 'Song request does not exist.'},
status=status.HTTP_400_BAD_REQUEST)
if song_request.played_at:
return Response({'detail': 'Song request was already played.'},
status=status.HTTP_400_BAD_REQUEST)
song_request.played_at = timezone.now() song_request.played_at = timezone.now()
song_request.save(update_fields=['played_at']) song_request.save(update_fields=['played_at'])
return Response(serializer.data) return Response(status=status.HTTP_204_NO_CONTENT)
return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
@ -81,5 +90,5 @@ class MakeRequest(APIView):
except MakeRequestError as e: except MakeRequestError as e:
return Response({'detail': str(e)}, return Response({'detail': str(e)},
status=status.HTTP_400_BAD_REQUEST) status=status.HTTP_400_BAD_REQUEST)
return Response(serializer.data) return Response(serializer.data, status=status.HTTP_201_CREATED)
return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)